Update stateful session cookie expiry on set #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aovens-quantifi is attempting to deploy a commit to the Auth0 Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for submitting a PR @aovens-quantifi - great catch! I'll take a look at this first thing tomorrow morning and get back to you |
cbstns
approved these changes
Mar 16, 2023
2 tasks
adamjmcgrath
approved these changes
Mar 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Currently stateful session cookies are not being updated on server interaction. The session expiry is being extended (according the the exp being sent to the session store) but without updating the cookie, this change is not having any effect. When the cookie expires, the session is lost.
📎 References
🎯 Testing
Implement a stateful session store. Open the Application tab in Chrome dev tools and find the session cookie. Refresh the page. Confirm that the cookie expiry increased in line with header.exp in the stored data