Remove type from export in d.ts files #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TypeScript 5.0.0 this is now a supported thing so it causes the imported values to be unusable, it seems like previous versions of TypeScript just ignored the type and would treat the import as a value Fixes #1035
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
7 tasks
adamjmcgrath
approved these changes
Jan 27, 2023
Merged
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Removes the
typefrom theexportin the d.ts files, as in TypeScript 5.0.0 this is now a supported thing so it causes the imported values to be unusable. It seems like previous versions of TypeScript just ignored thetypeand would treat the import as a value.📎 References
Fixes #1035
🎯 Testing
Can be tested by installing the nightly TS extension, enabling it per the docs and opening one of the provided samples in the linked issue, it should be flagged in the editor and then removing the
export typefromnode_modulesshould unflag it