OIDC Back-Channel Logout #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+54
to
+60
| app.get('/', async (req, res) => { | ||
| if (req.oidc.isAuthenticated()) { | ||
| res.send(`hello ${req.oidc.user.sub} <a href="/logout">logout</a>`); | ||
| } else { | ||
| res.send('<a href="/login">login</a>'); | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+21
to
+27
| app.get('/', async (req, res) => { | ||
| if (req.oidc.isAuthenticated()) { | ||
| res.send(`hello ${req.oidc.user.sub} <a href="/logout">logout</a>`); | ||
| } else { | ||
| res.send('<a href="/login">login</a>'); | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+53
to
+59
| app.get('/', async (req, res) => { | ||
| if (req.oidc.isAuthenticated()) { | ||
| res.send(`hello ${req.oidc.user.sub} <a href="/logout">logout</a>`); | ||
| } else { | ||
| res.send('<a href="/login">login</a>'); | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+80
to
+94
| router.use(async (req, res, next) => { | ||
| if (!req.oidc.isAuthenticated()) { | ||
| next(); | ||
| return; | ||
| } | ||
| try { | ||
| const loggedOut = await isLoggedOutFn(req, config); | ||
| if (loggedOut) { | ||
| req[config.session.name] = undefined; | ||
| } | ||
| next(); | ||
| } catch (e) { | ||
| next(e); | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
96f1226 to
86b21b2
Compare
86b21b2 to
791c9ab
Compare
adamjmcgrath
commented
Sep 12, 2023
| @@ -18,6 +18,7 @@ let encryption, signing; | |||
| * @see https://tools.ietf.org/html/rfc5869 | |||
| * | |||
| */ | |||
| /* istanbul ignore else */ | |||
There was a problem hiding this comment.
This doesn't get hit since I upgraded the circleci Node image - will go back and setup the CI to run on multiple Node versions in another PR
adamjmcgrath
commented
Sep 13, 2023
frederikprijck
approved these changes
Sep 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for OpenID Connect Back-Channel Logout https://openid.net/specs/openid-connect-backchannel-1_0.html
References
fixes #383
Testing
screencast.mp4
https://github.com/auth0-samples/auth0-express-webapp-sample/tree/backchannel-logout-demo/02-Back-Channel-Logout
Checklist