Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding domains update [CLI-184] #314

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Add branding domains update [CLI-184] #314

merged 3 commits into from
Jun 16, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jun 15, 2021

Description

Previously, the update command for custom domains could not be added, because the Go SDK did not support that method. Now that it has been added to the Go SDK, this PR updates the Go SDK to the latest commit and adds the branding domains update command.

Screen Shot 2021-06-15 at 16 21 05

Testing

This change has been tested manually with a proxy, to check that the modified values are correctly included in the request.

Screen Shot 2021-06-15 at 20 22 47

Screen Shot 2021-06-15 at 20 20 26

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team June 15, 2021 23:25
Copy link

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit 35d14f5 into main Jun 16, 2021
@Widcket Widcket deleted the update-custom-domain branch June 16, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants