Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/blacklist url scheme #644

Merged
merged 5 commits into from
May 5, 2020
Merged

Fix/blacklist url scheme #644

merged 5 commits into from
May 5, 2020

Conversation

Sambego
Copy link
Contributor

@Sambego Sambego commented Apr 8, 2020

Changes

  • The blacklistedRoutes needed to be specified with the correct protocol (http:// or https://) to work. This pull request added to option to blacklist a route regardless of the protocol. A configured blacklist routed prefixed with // will be blacklisted for both http:// and https://.
  • Compare hostName instead of host so this will work with HTTP requests to URLs with ports (:80 for HTTP, `:433 for HTTPS)
  • Updated the readme examples of blacklisted routes without protocol prefixed. this did not work.
  • Added more tests to check all allowed white and blacklist options

References

Checklist

@Sambego Sambego requested a review from stevehobbsdev April 8, 2020 10:10
@Sambego Sambego requested a review from a team as a code owner April 8, 2020 10:10
@Sambego Sambego self-assigned this Apr 8, 2020
@Sambego Sambego merged commit 07e880b into master May 5, 2020
@stevehobbsdev stevehobbsdev deleted the fix/blacklist-url-scheme branch May 5, 2020 14:50
@Sambego Sambego mentioned this pull request May 15, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants