Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0.0 #634

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Release 4.0.0 #634

merged 1 commit into from
Feb 7, 2020

Conversation

stevehobbsdev
Copy link

Version in package.json was already updated in a previous PR.

@stevehobbsdev stevehobbsdev added the tiny Tiny review label Feb 7, 2020
@stevehobbsdev stevehobbsdev requested a review from a team February 7, 2020 19:13
@lbalmaceda
Copy link
Contributor

Actually @stevehobbsdev, feels like if this is a new major the Changelog could be improved a bit. Maybe adding some migration guide, things that got removed, if any, etc etc.

@stevehobbsdev
Copy link
Author

@lbalmaceda The interface should actually be the same, there's nothing to migrate. However, releasing a new major allows opt-in without inadvertently breaking anyone. The library before #622 wasn't in the best shape and we were unable to easily validate changes. The changes in #622 give us more confidence going forward.

@stevehobbsdev stevehobbsdev merged commit 4a7b98e into master Feb 7, 2020
@stevehobbsdev stevehobbsdev deleted the prepare/4.0.0 branch February 7, 2020 20:50
@lbalmaceda
Copy link
Contributor

@stevehobbsdev The readme is still talking about the old version and its requirements. Please, make sure to update it to reflect anything introduced with this v4 release.

@stevehobbsdev
Copy link
Author

There's a couple of other things come to light too, will get it updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants