Refactor deep rxjs imports and use named define #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes `@auth0/angular-jwt` usable with Bazel. The fix consists of two parts: 1. Update of deep rxjs imports. They don't work with Bazel but also increase the final bundle size unnecessary. 2. Use named define for the library.
neilhem
reviewed
Jun 26, 2019
src/jwt.interceptor.ts
Outdated
| @@ -7,8 +7,7 @@ import { | |||
| } from '@angular/common/http'; | |||
| import { JwtHelperService } from './jwthelper.service'; | |||
| import { JWT_OPTIONS } from './jwtoptions.token'; | |||
| import { Observable } from "rxjs/internal/Observable"; | |||
| import { from } from "rxjs/internal/observable/from"; | |||
| import { from, Observable } from "rxjs"; | |||
There was a problem hiding this comment.
Just reused the current style.
There was a problem hiding this comment.
Would be good to have single quotes, but I'm going to do a Prettier pass on it before the next release anyway.
stevehobbsdev
approved these changes
Jun 26, 2019
src/jwt.interceptor.ts
Outdated
| @@ -7,8 +7,7 @@ import { | |||
| } from '@angular/common/http'; | |||
| import { JwtHelperService } from './jwthelper.service'; | |||
| import { JWT_OPTIONS } from './jwtoptions.token'; | |||
| import { Observable } from "rxjs/internal/Observable"; | |||
| import { from } from "rxjs/internal/observable/from"; | |||
| import { from, Observable } from "rxjs"; | |||
There was a problem hiding this comment.
Would be good to have single quotes, but I'm going to do a Prettier pass on it before the next release anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes
@auth0/angular-jwtusable with Bazel. The fix consistsof two parts:
increase the final bundle size unnecessary.
References
angular/angular-bazel-example#463
Checklist