Fix for the issue of wrong OTP codes #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
approved these changes
Apr 26, 2024
|
Hi! Any plan for releasing this? We're facing this issue in production when building the app with Xcode 15.3. |
Widcket
reviewed
May 1, 2024
| @@ -23,7 +23,7 @@ | |||
| import Foundation | |||
|
|
|||
| struct PushCredentials: Codable { | |||
| let service = "APNS" | |||
| private(set) var service = "APNS" | |||
There was a problem hiding this comment.
Is this being modified somewhere?
There was a problem hiding this comment.
It produces warning because of conforming to Codable. It is modified in the process of state restoring. There are several ways to fix the warning (like providing default value in init), but private setter is the best option here.
andy317fe301f8c7
approved these changes
May 2, 2024
Widcket
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue of wrong OTP codes
Removed other warnings in project