Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests to compile with Xcode 15 #803

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Update unit tests to compile with Xcode 15 #803

merged 3 commits into from
Oct 25, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 24, 2023 •
edited
Loading

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR disambiguates the Predicate type used in the custom matchers to use Nimble's Predicate instead of the newly introduced type in Swift 5.9.

Also, it gates a unit test to run only with Xcode < 15 because the mismatch in behavior between the initializers of URLComponents and URL that motivated it has been fixed in Xcode 15: https://forums.swift.org/t/url-string-behavior-changed-with-xcode-15-0-beta-5/66570

@Widcket Widcket added the review:small Small review label Oct 24, 2023
@Widcket Widcket requested a review from a team as a code owner October 24, 2023 17:55
@Widcket Widcket enabled auto-merge (squash) October 24, 2023 22:22
@Widcket Widcket merged commit 83feebb into master Oct 25, 2023
10 checks passed
@Widcket Widcket deleted the test/xcode-15 branch October 25, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @ewanharris