Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a case-sensitive compare for org_name #783

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Use a case-sensitive compare for org_name #783

merged 1 commit into from
Jul 18, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 18, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR changes the comparison of the expected and actual org_name claim to be case-sensitive, and only lowercasing the expected value.

@Widcket Widcket requested a review from a team as a code owner July 18, 2023 09:26
@Widcket Widcket added the review:tiny Tiny review label Jul 18, 2023
@Widcket Widcket merged commit ad781b2 into master Jul 18, 2023
@Widcket Widcket deleted the fix/case-sensitive-org-name branch July 18, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @frederikprijck