Simplify implementation of custom Web Auth providers #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
approved these changes
May 20, 2022
Widcket
added a commit
that referenced
this pull request
May 26, 2022
* Add custom Web Auth providers implementation [SDK-3333] (#688) * Implement custom Web Auth user agents * Use a static factory * Rename Safari provider methods * Move custom description into user agents * Remove optionals * Add comment to SafariUserAgent * Simplify implementation * Return the closures directly * Move Safari provider inside the library * Handle other ASWebAuthenticationSessionError cases * Move common logic to an extension * Fix tests * Remove whitespace * Simplify implementation of custom Web Auth providers (#691) * Add unit tests [SDK-3335] (#692) * Add unit tests * Remove unnecessary import * Fix matcher name * Use ASProvider in WebAuth test * Add platform guards * Update Auth0Tests/SafariProviderSpec.swift Co-authored-by: Adam Mcgrath <adam.mcgrath@auth0.com> * Add additional unit tests (#694) * Simplify the implementation some more (#695) * Add API documentation (#697) * Add API documentation * Add link to example implementation * Update Auth0/WebAuthUserAgent.swift * Update Auth0/WebAuthUserAgent.swift * Update FAQ and README (#698) Co-authored-by: Adam Mcgrath <adam.mcgrath@auth0.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR simplifies the implementation of the custom Web Auth providers, by using a single callback to communicate the result to the user agent and consolidating the
ASWebAuthenticationSessionimplementation to match theSFSafariViewControllerone.🎯 Testing
The changes have been tested manually on an iPhone 13 simulator running iOS 15.5, with Xcode Version 13.4 (13F17a).