Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Web Auth method embedded in Authentication API client #560

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 1, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

The Authentication API client has a method webAuth(withConnection:) that actually uses Web Auth under the hood. Its implementation is:

func webAuth(withConnection connection: String) -> WebAuth {
        let webAuth = Auth0WebAuth(clientId: self.clientId, url: self.url, telemetry: self.telemetry)
        return webAuth
            .logging(enabled: self.logger != nil)
            .connection(connection)
    }

Besides being unnecessary, it is confusing, so this PR removes it in favor of just using Auth0.webAuth().connection().

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added the review:small Small review label Dec 1, 2021
@Widcket Widcket requested a review from a team as a code owner December 1, 2021 16:02
@Widcket Widcket requested a review from adamjmcgrath December 1, 2021 16:04
@Widcket Widcket merged commit 13296ce into beta Dec 1, 2021
@Widcket Widcket deleted the v2/webauth-connection branch December 1, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants