Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover files #555

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Remove leftover files #555

merged 4 commits into from
Nov 29, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 29, 2021

Changes

This PR removes the bridging headers of the test target, which are not needed anymore, and the ObjectiveC/include/headers.h file as well. Also, the tvOS test app was using a separate Info.plist file from the other apps, and it was changed to use the same one.

Additionally, the Package.swift was added to the pbxproj so it can be opened from Xcode.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner November 29, 2021 15:15
@Widcket Widcket added review:tiny Tiny review review:small Small review and removed review:tiny Tiny review labels Nov 29, 2021
@Widcket Widcket merged commit 1931514 into beta Nov 29, 2021
@Widcket Widcket deleted the v2/leftover-files branch November 29, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants