Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom Result type [SDK-2901] #542

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Remove custom Result type [SDK-2901] #542

merged 3 commits into from
Nov 10, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 10, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

The library had a custom Result type that became superfluous given that Swift 5 has a built-in one. That custom type was removed (along with its shims), and an Auth0Result type alias was added to wrap the Swift Result type.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket changed the title Remove custom Result type Remove custom Result type [SDK-2901] Nov 10, 2021
@Widcket Widcket marked this pull request as ready for review November 10, 2021 13:32
@Widcket Widcket requested a review from a team as a code owner November 10, 2021 13:32
@Widcket Widcket requested a review from adamjmcgrath November 10, 2021 13:32
@Widcket Widcket added the review:small Small review label Nov 10, 2021
@Widcket Widcket merged commit 5be2582 into beta Nov 10, 2021
@Widcket Widcket deleted the v2/remove-result branch November 10, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants