Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Objective-C [SDK-2894] #539

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Drop support for Objective-C [SDK-2894] #539

merged 4 commits into from
Nov 9, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 9, 2021 •
edited
Loading

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

The following Objective-C compatibility wrappers were removed:

  • _ObjectiveAuthenticationAPI
  • _ObjectiveManagementAPI
  • _ObjectiveOAuth2

An extension on NSError containing two properties was removed as well, and all the properties from Credentials and UserInfo are no longer marked with @objc. Consequently, UserInfo was changed from class to struct, as it no longer needed to inherit from NSObject.

Credentials still needs to inherit from NSObject due to the usage of NSSecureCoding, which will be addressed in a future PR.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner November 9, 2021 00:00
@Widcket Widcket marked this pull request as draft November 9, 2021 00:00
@Widcket Widcket changed the base branch from master to beta November 9, 2021 00:01
@Widcket Widcket added the review:small Small review label Nov 9, 2021
@Widcket Widcket marked this pull request as ready for review November 9, 2021 14:05
@Widcket Widcket requested a review from adamjmcgrath November 9, 2021 14:26
@Widcket Widcket merged commit 2194045 into beta Nov 9, 2021
@Widcket Widcket deleted the v2/drop-objc branch November 9, 2021 15:06
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @adamjmcgrath