Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop platform versions [SDK-2895] #527

Merged
merged 12 commits into from
Nov 3, 2021
Merged

Drop platform versions [SDK-2895] #527

merged 12 commits into from
Nov 3, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 1, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

The deployment targets were bumped to:

  • iOS 12.0
  • macOS 10.15
  • Mac Catalyst 13.0
  • tvOS 12.0
  • watchOS 6.2

Since ASWebAuthenticationSession supports iOS 12+, the WebAuth strategies for the older iOS versions were removed. That means there is no longer a need to keep different Web Auth implementations for macOS and iOS, as both use ASWebAuthenticationSession only now, so the BaseWebAuth subclasses were removed, and BaseWebAuth was renamed to Auth0WebAuth, which is the name it had before the split.

Similarly, SessionTransaction was merged back into BaseAuthTransaction, and BaseAuthTransaction was renamed to BaseTransaction. And the AuthResumable and AuthCancelable protocols were subsumed into AuthTransaction.

Finally, all the conditional compilation blocks that were targeting older platforms (and the new minimums) were removed.

Removed

  • Auth0/A0SimpleKeychain+RSAPublicKey.swift
  • Auth0/ControllerModalPresenter.swift
  • Auth0/SafariSession.swift
  • Auth0/SilentSafariViewController.swift
  • Auth0/SessionTransaction.swift

Renamed

  • Auth0/AuthenticationServicesSession.swift -> Auth0/ASTransaction.swift
  • Auth0/AuthenticationServicesSessionCallback.swift -> Auth0/ASCallbackTransaction.swift
  • Auth0/SessionCallbackTransaction.swift -> Auth0/BaseCallbackTransaction.swift
  • Auth0/BaseAuthTransaction.swift -> Auth0/BaseTransaction.swift
  • Auth0/BaseWebAuth.swift -> Auth0/Auth0WebAuth.swift
  • Auth0/WebAuthenticatable.swift -> Auth0/WebAuth.swift

Testing

The changes have been tested manually, by performing Web Auth login and logout in test apps, as follows:

Using Cocoapods

  • iOS (simulator)
  • macOS
  • macOS Catalyst

Using Carthage

  • iOS (simulator)
  • macOS
  • macOS Catalyst Carthage does not support building XCFrameworks for macCatalyst

Using SPM

  • iOS (simulator)
  • macOS
  • macOS Catalyst

Checklist

@Widcket Widcket changed the title Drop platform versions Drop platform versions [SDK-2895] Nov 2, 2021
@Widcket Widcket changed the base branch from master to beta November 2, 2021 20:12
@Widcket Widcket marked this pull request as ready for review November 3, 2021 13:15
@Widcket Widcket requested a review from a team as a code owner November 3, 2021 13:15
@Widcket Widcket merged commit c71d2f3 into beta Nov 3, 2021
@Widcket Widcket deleted the v2/drop-platforms branch November 3, 2021 14:30
@Widcket Widcket added the review:medium Medium review label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:medium Medium review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants