Use Swift's built-in Result type when available #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ejensen, thanks for the PR. I expect to review this towards the end of the week. |
|
Hi, I haven't been able to get to this yet. Should be done this week. Apologies for the delay. |
|
@ejensen thanks for this PR! |
Widcket
approved these changes
Apr 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Followup on PR #433
Replaces the conflicting public
Resulttype with theResulttype built into the Swift Standard Library when Swift 5.0+ is used.This prevents type conflicts while minimizing changes to the existing Auth0 interface. This is a non-breaking change in both Swift < 5.0 and Swift >= 5.0. The deprecated shims for the old named parameters provide auto-fix-its to the warnings by migrating to the Swift standard interface.
References
Testing
Checklist