Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add a max_age if one was provided #452

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Always add a max_age if one was provided #452

merged 1 commit into from
Feb 12, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 12, 2021 •
edited
Loading

Changes

Currently, if a max_age was provided it would only be added to the authorize URL if the response type contained id_token. Since an ID Token will also come when the response type is code (the default), this PR adds a max_age whenever one is provided.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner February 12, 2021 15:10
@Widcket Widcket merged commit 83640c3 into master Feb 12, 2021
@Widcket Widcket deleted the fix/max-age branch February 12, 2021 15:32
@Widcket Widcket added this to the vNext milestone Feb 12, 2021
@Widcket Widcket mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:tiny Tiny review
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @lbalmaceda