Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for minTTL on CredentialsManager.swift #420

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Bugfix for minTTL on CredentialsManager.swift #420

merged 3 commits into from
Sep 28, 2020

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Sep 25, 2020 •
edited
Loading

Changes

Bugfix for minTTL on CredentialsManager.swift.
TimeInterval are in seconds already, so no need to multiply or divide by 1000

Please describe both what is changing and why this is important. Include:

References

No references

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@heyzooi heyzooi requested a review from a team September 25, 2020 17:46
@Widcket
Copy link
Contributor

Widcket commented Sep 25, 2020

@heyzooi thanks for the PR!

@Widcket Widcket added this to the vNext milestone Sep 25, 2020
@Widcket Widcket merged commit 448db4c into auth0:master Sep 28, 2020
@heyzooi heyzooi deleted the heyzooi-patch-1 branch September 30, 2020 15:02
@Widcket Widcket mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@heyzooi @Widcket