Move NativeAuth.start() into the NativeAuth protocol declaration #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moves
NativeAuth.start()
into theNativeAuth
protocol declaration. This allows SDK clients to provide an implementation. Rather than restricting it to the default implementation defined in the protocol extension.This enables clients to write their own implementation of
start
. For example, we need to callauthentication.login(facebookSessionAccessToken: ...)
in our implementation of the protocol, rather thanauthentication.loginSocial(token:...)
that's called by the default protocol extension implementation.This is a non-breaking change to the protocol.
References
Testing
No additional testing is required since this is an inert change to a protocol
Checklist