Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Facebook token exchange method [SDK-1401] #358

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Added Facebook token exchange method [SDK-1401] #358

merged 1 commit into from
Mar 3, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 29, 2020 •
edited
Loading

Changes

Added

  • Added a public method tokenExchange(withFacebookSessionAccessToken:profile:scope:audience:) to exchange Facebook's session info access token and profile data for Auth0 credentials.
  • Added a default implementation for that method in the Authentication protocol, that sets default values for the optional parameters.
  • Added unit tests for the new method.

Changed

  • Moved Auth0Authentication private methods into a private extension to avoid a linter warning due to the length of the struct body.

Fixed

  • Explicitly passing nil as the scope value is now respected in the Apple token exchange method. This is backwards-compatible, since nil was the previous default value in that method.
  • Fixed a linter whitespace warning.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team February 29, 2020 01:57
@Widcket Widcket changed the title Implemented Facebook token exchange method [SDK-1401] Added Facebook token exchange method [SDK-1401] Feb 29, 2020
@Widcket Widcket added this to the vNext milestone Feb 29, 2020
@Widcket Widcket requested a review from lbalmaceda February 29, 2020 01:59
@Widcket Widcket requested a review from lbalmaceda March 3, 2020 12:56
@Widcket Widcket merged commit 2f32e0d into master Mar 3, 2020
@Widcket Widcket deleted the feature/fb-token-exchange branch March 3, 2020 17:45
sam-w pushed a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
@Widcket @sam-w
Implement Facebook token exchange method (auth0#358)
13e9060
sam-w added a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
@sam-w
Revert "Implement Facebook token exchange method (auth0#358)"
c04eeb0 
This reverts commit 13e9060.
@Widcket Widcket mentioned this pull request Mar 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @lbalmaceda