-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extended profile using SIWA token exchange #322
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
567cbdc
Add support for extended profile using SIWA token exchange
7a6733e
Fix indenting/whitespace
cb9abbc
Revert accidental Cartfile.resolved changes
71128a5
Reorder SIWA parameters, and stop sending missing values
341cf65
Expand test cases for SIWA
5da6d4c
Merge branch 'master' into IPS-772
cocojoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -242,6 +242,14 @@ class AuthenticationSpec: QuickSpec { | |
"scope": "openid email", | ||
"audience": "https://myapi.com/api" | ||
])) { _ in return authResponse(accessToken: AccessToken, idToken: IdToken) }.name = "Token Exchange Apple Success with custom scope and audience" | ||
|
||
stub(condition: isToken(Domain) && hasAtLeast([ | ||
"grant_type": "urn:ietf:params:oauth:grant-type:token-exchange", | ||
"subject_token": "VALIDNAMECODE", | ||
"subject_token_type": "http://auth0.com/oauth/token-type/apple-authz-code"]) && | ||
(hasAtLeast(["user_profile": "{\"name\":{\"lastName\":\"Smith\",\"firstName\":\"John\"}}" ]) || hasAtLeast(["user_profile": "{\"name\":{\"firstName\":\"John\",\"lastName\":\"Smith\"}}" ])) | ||
) { _ in return authResponse(accessToken: AccessToken, idToken: IdToken) }.name = "Token Exchange Apple Success with user profile" | ||
|
||
} | ||
|
||
it("should exchange apple auth code for credentials") { | ||
|
@@ -284,8 +292,24 @@ class AuthenticationSpec: QuickSpec { | |
} | ||
} | ||
|
||
} | ||
it("should exchange apple auth code for credentials with fullName") { | ||
var fullName = PersonNameComponents() | ||
fullName.givenName = "John" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please add test cases for when the name and/or surname are nil? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added. |
||
fullName.familyName = "Smith" | ||
fullName.middleName = "Ignored" | ||
|
||
waitUntil(timeout: Timeout) { done in | ||
auth.tokenExchange(withAppleAuthorizationCode: "VALIDNAMECODE", | ||
fullName: fullName) | ||
.start { result in | ||
expect(result).to(haveCredentials()) | ||
done() | ||
} | ||
} | ||
} | ||
|
||
} | ||
|
||
describe("revoke refresh token") { | ||
|
||
let refreshToken = UUID().uuidString.replacingOccurrences(of: "-", with: "") | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any cases it will fail e.g. if first name is missing or last name is missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there are not. The values can be missing or
null
and it won't cause any issues. Now, I've filtered them out if there is no value.