Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SIWA token exchange support #304

Merged
merged 7 commits into from
Sep 19, 2019
Merged

Added SIWA token exchange support #304

merged 7 commits into from
Sep 19, 2019

Conversation

cocojoe
Copy link
Member

@cocojoe cocojoe commented Aug 31, 2019 •
edited
Loading

Changes

New endpoint added for SIWA token exchange

func tokenExchange(withAppleAuthorizationCode authCode: String, scope: String? = nil, audience: String? = nil) -> Request<Credentials, AuthenticationError>

Added Docs to README

References

Internal

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@cocojoe cocojoe requested a review from a team August 31, 2019 18:05
@cocojoe cocojoe changed the title Added SIWA token exchange endpoint support [WIP] Added SIWA token exchange endpoint support Aug 31, 2019
@cocojoe cocojoe changed the title [WIP] Added SIWA token exchange endpoint support Added SIWA token exchange endpoint support Sep 2, 2019
@cocojoe cocojoe added this to the vNext milestone Sep 3, 2019
hzalaz
hzalaz previously approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@hzalaz hzalaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd not use tokenExchange but rather login or similar but is just a detail

joshcanhelp
joshcanhelp previously approved these changes Sep 3, 2019
View reviewed changes
@cocojoe
Copy link
Member Author

cocojoe commented Sep 4, 2019

Thanks, I'm going to leave it open for a bit for any additional validation.

@cocojoe cocojoe modified the milestones: 1.17.1, vNext Sep 4, 2019
@cocojoe cocojoe changed the title Added SIWA token exchange endpoint support [DO NOT MERGE] Added SIWA token exchange endpoint support Sep 5, 2019
@cocojoe cocojoe dismissed stale reviews from joshcanhelp and hzalaz via 087edbf September 16, 2019 11:53
@cocojoe cocojoe changed the title [DO NOT MERGE] Added SIWA token exchange endpoint support Added token exchange endpoint SIWA support Sep 16, 2019
@cocojoe cocojoe changed the title Added token exchange endpoint SIWA support Added SIWA token exchange support Sep 16, 2019
@cocojoe cocojoe force-pushed the added-apple-token-exchange branch from 087edbf to 6c713f8 Compare September 16, 2019 12:08
@cocojoe cocojoe mentioned this pull request Sep 16, 2019
Closed
@cocojoe cocojoe merged commit c8e98b4 into master Sep 19, 2019
@cocojoe cocojoe deleted the added-apple-token-exchange branch September 19, 2019 19:28
@cocojoe cocojoe mentioned this pull request Sep 20, 2019
Merged
sam-w pushed a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
@cocojoe @sam-w
Added SIWA token exchange support (auth0#304)
8f63d5e 
* Added Apple Token Exchange
* Added Tests
* Added audience
sam-w added a commit to LoungeBuddy/Auth0.swift that referenced this pull request Mar 11, 2020
@sam-w
Revert "Added SIWA token exchange support (auth0#304)"
305e4d5 
This reverts commit 8f63d5e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

@joshcanhelp joshcanhelp joshcanhelp left review comments

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cocojoe @joshcanhelp @hzalaz