Ensure URL encoding of + as %2B Authorize URL [SDK-691] #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
commented
Mar 14, 2019
| @@ -181,6 +181,7 @@ class SafariWebAuth: WebAuth { | |||
|
|
|||
| entries.forEach { items.append(URLQueryItem(name: $0, value: $1)) } | |||
| components.queryItems = self.telemetry.queryItemsWithTelemetry(queryItems: items) | |||
| components.percentEncodedQuery = components.percentEncodedQuery?.replacingOccurrences(of: "+", with: "%2B") | |||
There was a problem hiding this comment.
I had a look at encoding at the key value. However, then the URL will end up double encoded. So this also appears to be the okay by apple http://www.openradar.me/24076063
There was a problem hiding this comment.
Ugh. Thanks for the link
cocojoe
commented
Mar 14, 2019
| let url = newWebAuth() | ||
| .parameters(["login_hint": "first+last@host.com"]) | ||
| .buildAuthorizeURL(withRedirectURL: RedirectURL, defaults: defaults, state: "state") | ||
| expect(url.absoluteString.contains("first%2Blast@host.com")).to(beTrue()) |
lbalmaceda
approved these changes
Mar 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
URL Encoding has changed to force encoding of
+to%2Bso+can be usedas expected for the
login_hintto pre-populate the ULP form.References
Internally raised issue.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist