Fixed client ID and redirect URL query items not being passed in nonfederated clearSession() #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no query items are present in the URL components when constructing the clear session URL, the client ID and redirect URL query items were not added to the URL. This results in the web auth clear session never calling back successfully. This change ensures that the client ID and redirect URL are always added to the clear session URL.
|
I couldn't find a good way to test either, which is a bit annoying now as would have caught this. One way would be to have a mock SFAuthenticationSession, however would need to open up the class to allow for passing of this object. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in issue #187, if no query items are present in the URL components when constructing
the clear session URL, the client ID and redirect URL query items are not added to the URL. This results in the web auth clear session never calling back successfully from the
SFAuthenticationSession.This change ensures that the client ID and redirect URL are always added to the clear session URL in the situation where the
federatedquery item is not present.