Fix request to patch user metadata #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Jan 12, 2021
| val patch = factory.patch( | ||
| url.toString(), | ||
| userProfileAdapter | ||
| ) as BaseRequest<UserProfile, ManagementException> |
There was a problem hiding this comment.
"unsafe cast": would throw if the cast cannot be made. But we know the type our RequestFactor uses internally.
lbalmaceda
commented
Jan 12, 2021
| @@ -40,7 +40,8 @@ public class DefaultClient() : NetworkingClient { | |||
| when (options.method) { | |||
| is HttpMethod.GET -> { | |||
| // add parameters as query | |||
| options.parameters.map { urlBuilder.addQueryParameter(it.key, it.value) } | |||
| options.parameters.filterValues { it is String } | |||
There was a problem hiding this comment.
when building the query, OKHttp requires us to pass String? type for the values. I'm filtering those that are not a String. Since the Request interface requires String, String this should not be an issue for Requests built by our API clients.
348472f to
d964c43
Compare
jimmyjames
approved these changes
Jan 12, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The serialization of the
user_metadataparameter was broken, as the internal classes required a String value to be passed, and the server expected an object / dictionary.The solution proposed here involves an internal method (not exposed) and a cast to a type we know it's the right expected one, as the
RequestFactoryimplementation that provides the request instance is ours as well.The
RequestOptionshad to be changed to support being passed parameters of theAny(Object) type. This is this way since if we provide a hidden internal implementation that handles this one scenario and let the interface as it was, we could be leaving out those developers that decide to extend the NetworkingClient and implement their own PATCH requests; as they would still be receiving a String value.