SecureCredentialsManager: Allow to pass scope and minTTL #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Nov 3, 2020
auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/main/java/com/auth0/android/authentication/storage/SecureCredentialsManager.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/test/java/com/auth0/android/authentication/storage/SecureCredentialsManagerTest.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/test/java/com/auth0/android/authentication/storage/SecureCredentialsManagerTest.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/test/java/com/auth0/android/authentication/storage/SecureCredentialsManagerTest.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/test/java/com/auth0/android/authentication/storage/SecureCredentialsManagerTest.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 3, 2020
auth0/src/main/java/com/auth0/android/authentication/storage/BaseCredentialsManager.java
Outdated
Show resolved
Hide resolved
Widcket
previously approved these changes
Nov 3, 2020
…aseCredentialsManager.java Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves the feature parity with iOS' CredentialManager class. Now developers can specify a reduced scope for when the tokens expire and need to be refreshed. And also a minimum time to live that the received tokens must have.
In order to add support for this, a new method was introduced. The old functionality remains the same.
Non breaking update
A test was included to check that current users of the SecureCredentialsManager are not "logged out" if the access token's expires_at value was not previously stored. The test is named
shouldHaveValidCredentialsDuringMigrationWhenAccessTokenExpiresAtValueWasNotSavedReferences
Relates to #349
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors