Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SSO error to go through #161

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Allow SSO error to go through #161

merged 1 commit into from
Jun 5, 2018

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented May 28, 2018 •
edited
Loading

Previously, authentication flows not contemplated for mobile/public clients where not allowed and captured as "configuration errors". SSO is one exception we would now like to allow. This PR fixes that (#160)

Things open to discussion:

  • the getter name: exception.isLoginRequired()
  • whether the error description should be the same as the one returned by the server ("Login Required") or something else, maybe more dev friendly.

@lbalmaceda lbalmaceda requested a review from cocojoe May 28, 2018 20:51
@lbalmaceda lbalmaceda added this to the v1-Next milestone May 28, 2018
cocojoe
cocojoe approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda merged commit 70bd117 into master Jun 5, 2018
@lbalmaceda lbalmaceda deleted the allow-sso branch June 5, 2018 14:05
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.13.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @cocojoe