Allow Custom Tabs UI to be customizable #111
Conversation
| @@ -124,6 +124,7 @@ public void run() { | |||
| Log.d(TAG, "Launching URI. Custom Tabs available: " + available); | |||
|
|
|||
| final Intent intent = new CustomTabsIntent.Builder(session.get()) | |||
| .setShowTitle(true) | |||
There was a problem hiding this comment.
Should this be optional? I am not too keen to force all users for a single person gh issue
There was a problem hiding this comment.
Ok. But anyway the title is no different than Login in with {YOUR_APP_NAME} as is set by the hosted page (I don't know if it can be changed). I'll add in this same PR a builder/style to customize this and the toolbar color.
|
I'd really like to see this merged. What's the current status of this change? |
|
@twaddington it's missing the methods to hide/show the title and change the toolbar color. I'll try to add them before eow. |
|
@lbalmaceda thanks! I personally wouldn't mind if the title just always showed and was not configurable. Not sure how others would like that though. |
|
@twaddington I know but we should let devs make that decision. 👍 |
16fe36b to
9dafed5
Compare
|
Let's see some screenshots. |
|
Y'all are awesome. Thanks! |
|
Please test it and give us feedback. Thanks |
Displaying the page title should be the default and only behavior, along with showing the current page domain.
This PR doesn't add the ability to turn this off (hide title).A builder class is provided to customize the CT UI options.
Related: #106