Merge pull request #32 from auth0/deprecate-webview

Remove Deprecated WebView/Fullscreen options
auth0 · Oct 14, 2016 · 506fbc5 · 506fbc5
2 parents 078f3e1 + 797c4ed
commit 506fbc5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 44 deletions.
diff --git a/README.md b/README.md
@@ -244,39 +244,6 @@ First go to [Auth0 Dashboard](https://manage.auth0.com/#/applications) and go to
 https://{YOUR_AUTH0_DOMAIN}/android/{YOUR_APP_PACKAGE_NAME}/callback
 ```
 
-#### Configuration: Using the WebView
-
-Open your app's `AndroidManifest.xml` file and add the following permissions.
-
-```xml
-<uses-permission android:name="android.permission.INTERNET" />
-<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
-```
-
-> The `ACCESS_NETWORK_STATE` permission it's not mandatory, but used by the WebAuthActivity to check for internet availability before executing a request.
-
-Also register the WebAuthActivity inside the `application` tag like
-
-
-```xml
-    <application android:theme="@style/AppTheme">
-
-        <!-- ... -->
-
-        <activity
-            android:name="com.auth0.android.provider.WebAuthActivity"
-            android:theme="@style/MyAppTheme"/>
-
-        <!-- ... -->
-
-    </application>
-```
-
-Finally, define a constant like `WEB_REQ_CODE` that holds the request code (an `int`), that will be sent back with the intent once the authentication is finished in the webview.
-
-
-#### Configuration: Using the Browser
-
 Open your app's `AndroidManifest.xml` file and add the following permission.
 
 ```xml
@@ -361,16 +328,6 @@ WebAuthProvider.init(account)
                 .start(MainActivity.this, authCallback, WEB_REQ_CODE);
 ```
 
-#### Use browser instead of WebView
-
-```java
-WebAuthProvider.init(account)
-                .useBrowser(true)
-                .start(MainActivity.this, authCallback, WEB_REQ_CODE);
-```
-> Make sure to check the callback url and manifest configuration explained above.
-
-
 #### Specify scope
 
 ```java
@@ -393,7 +350,6 @@ WebAuthProvider.init(account)
 
 ```java
 WebAuthProvider.init(account)
-                .useBrowser(true)
                 .start(MainActivity.this, authCallback, WEB_REQ_CODE);
 ```
 

diff --git a/auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java b/auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
@@ -126,7 +126,9 @@ public static class Builder {
          *
          * @param useBrowser if the authentication is handled in a Browser.
          * @return the current builder instance
+         * @deprecated This method has been deprecated since Google is no longer supporting WebViews to perform login.
          */
+        @Deprecated
         public Builder useBrowser(boolean useBrowser) {
             this.useBrowser = useBrowser;
             return this;
@@ -138,7 +140,9 @@ public Builder useBrowser(boolean useBrowser) {
          *
          * @param useFullscreen if the activity should be fullscreen or not.
          * @return the current builder instance
+         * @deprecated This method has been deprecated since it's only applied to WebView authentication and Google is no longer supporting them to perform login.
          */
+        @Deprecated
         public Builder useFullscreen(boolean useFullscreen) {
             this.useFullscreen = useFullscreen;
             return this;