Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi files opening #46

Merged
merged 2 commits into from
Apr 6, 2017
Merged

support multi files opening #46

merged 2 commits into from
Apr 6, 2017

Conversation

randy3k
Copy link
Contributor

@randy3k randy3k commented Dec 2, 2015

As in the official rmate, it supports opening multiple files. rmate foo.txt bar.txt baz.txt.
I basically wrap the original code in the function open_file and do a for loop

for file in "${filepaths[@]}"; do
    open_file "$file"
done

@randy3k
Copy link
Contributor Author

randy3k commented Dec 2, 2015

Ops....each file should have its corresponding --line, --name and --type arguments.

@randy3k
Copy link
Contributor Author

randy3k commented Dec 2, 2015

Tested again on textmate and atom. And apparently, sublime doesn't support it.

@aurora
Copy link
Owner

aurora commented Dec 2, 2015

@randy3k hey, i have to take a further look at this, because it seems to be quite a big change. but due to health reasons it'll take some weeks until i can look into it ...

@randy3k
Copy link
Contributor Author

randy3k commented Dec 2, 2015

Take your time. I totally understand it.

@tiennou
Copy link

tiennou commented Oct 7, 2016

I've been using that version a few times on various Linux-based server, and it works quite well.

@randy3k
Copy link
Contributor Author

randy3k commented Apr 5, 2017

@aurora

this has been sitting here for 1.5 year, how do you think about it?

@aurora
Copy link
Owner

aurora commented Apr 6, 2017

@randy3k i am really sorry about the long delay, i am going to merge it. Thanks very much for your work and your patience on this :-)!

@aurora aurora merged commit 59980a0 into aurora:master Apr 6, 2017
@aurora aurora mentioned this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants