Lint protobuf files, place in xviz.v2 package, ensure bazel compat #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using Uber's prototool 1.7 for lint with the provided prototool.yaml setting which rules we are not following. These are not being followed so that JSON emitted and consumed by the protobuf types matches that in the JSON schema. Bazel compatibility allows other projects to pull in our source releases and use the protobuf rules directly. See the `docs/protocol-formats/protobuf-protocol.md` for more details on Bazel and lint/formatting.
twojtasz
approved these changes
Jun 3, 2019
jlisee
added a commit
that referenced
this pull request
Jun 3, 2019
We are using Uber's prototool 1.7 for lint with the provided prototool.yaml setting which rules we are not following. These are not being followed so that JSON emitted and consumed by the protobuf types matches that in the JSON schema. Bazel compatibility allows other projects to pull in our source releases and use the protobuf rules directly. See the `docs/protocol-formats/protobuf-protocol.md` for more details on Bazel and lint/formatting.
|
Note I merged this one incorrect (stacked PR's are still new to me) so I pushed this manually to master. |
alexhaislip
pushed a commit
to Smart-Ag/xviz
that referenced
this pull request
Aug 2, 2021
…rora-opensource#476) We are using Uber's prototool 1.7 for lint with the provided prototool.yaml setting which rules we are not following. These are not being followed so that JSON emitted and consumed by the protobuf types matches that in the JSON schema. Bazel compatibility allows other projects to pull in our source releases and use the protobuf rules directly. See the `docs/protocol-formats/protobuf-protocol.md` for more details on Bazel and lint/formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Uber's prototool 1.7 for lint with the provided
prototool.yaml setting which rules we are not following. These are not
being followed so that JSON emitted and consumed by the protobuf types
matches that in the JSON schema.
Bazel compatibility allows other projects to pull in our source
releases and use the protobuf rules directly.
See the
docs/protocol-formats/protobuf-protocol.mdfor more detailson Bazel and lint/formatting.