Fix(xcc): Store the first upgradable XCC version in state #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
approved these changes
Dec 4, 2023
aleksuss
approved these changes
Dec 5, 2023
aleksuss
pushed a commit
that referenced
this pull request
Dec 6, 2023
## Description In #866 I introduced a change to the XCC router where the contract became upgradable. In that PR I hardcoded that any XCC Router that was version 1 could not be upgraded, however this logic did not work on testnet where the XCC Router code had already been set twice, so it was actually version 3 which became the first upgradable version. In this PR I add a new key to the engine which stores the first upgradable XCC version so that it does not need to be hardcoded. This should allow the logic to work properly on both testnet and mainnet. ## Performance / NEAR gas cost considerations N/A ## Testing Existing tests + testnet deployment (manual test)
Merged
aleksuss
added a commit
that referenced
this pull request
Dec 6, 2023
## 3.5.0 2023-12-06 ### Additions - Added a new transaction `upgrade` which allows upgrading the contract and invoking the `state_migration` callback with one call by [@aleksuss]. ([#878]) ### Fixes - Updated the logic of upgrading XCC router which works properly on both `mainnet` and `testnet` by [@birchmd]. ([#877]) [#877]: #877 [#878]: #878 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
aleksuss
added a commit
to aleksuss/aurora-engine
that referenced
this pull request
Dec 6, 2023
## 3.5.0 2023-12-06 ### Additions - Added a new transaction `upgrade` which allows upgrading the contract and invoking the `state_migration` callback with one call by [@aleksuss]. ([aurora-is-near#878]) ### Fixes - Updated the logic of upgrading XCC router which works properly on both `mainnet` and `testnet` by [@birchmd]. ([aurora-is-near#877]) [aurora-is-near#877]: aurora-is-near#877 [aurora-is-near#878]: aurora-is-near#878 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
aleksuss
added a commit
that referenced
this pull request
Dec 6, 2023
## 3.5.0 2023-12-06 ### Additions - Added a new transaction `upgrade` which allows upgrading the contract and invoking the `state_migration` callback with one call by [@aleksuss]. ([#878]) ### Fixes - Updated the logic of upgrading XCC router which works properly on both `mainnet` and `testnet` by [@birchmd]. ([#877]) [#877]: #877 [#878]: #878 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #866 I introduced a change to the XCC router where the contract became upgradable. In that PR I hardcoded that any XCC Router that was version 1 could not be upgraded, however this logic did not work on testnet where the XCC Router code had already been set twice, so it was actually version 3 which became the first upgradable version.
In this PR I add a new key to the engine which stores the first upgradable XCC version so that it does not need to be hardcoded. This should allow the logic to work properly on both testnet and mainnet.
Performance / NEAR gas cost considerations
N/A
Testing
Existing tests + testnet deployment (manual test)