chore: use owner account in engine authorizer #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no performance impact despite reading from storage because this is a read only method, correct? |
|
I guess you mean increasing gas costs? I think it increases gas costs a bit, even if this is a read-only operation because read-only ops are not free. But we don't have to worry about that because it's a rare operation ( |
mrLSD
approved these changes
Mar 31, 2023
vimpunk
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR allows using an owner account in the
EngineAuthorizerrather than a hardcodedauroraaccount.Performance / NEAR gas cost considerations
There should be no changes in the performance.