feat: return formatted custom messages #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshuajbouw Looking good, but please check the Clippy errors |
mrLSD
pushed a commit
that referenced
this pull request
May 5, 2021
* Link to docs in the README. (#18) * Change deprecated `u64::max_value` to `u64::MAX`. (#38) * Support custom error messages. (#40) * Implement `begin_chain` for evm-bully. (#30) * Implement a faucet method. (#39) * Implement all Istanbul HF precompiles. (#21) * Check and increment nonces. (#42) * Fix the RIPEMD160 and ModExp precompiles. (#44) * Implement a first draft of `COINBASE` and `GASLIMIT`. (#47) * Refactor and improve error handling. (#49) * Replace `raw_call` with the new `submit` API. (#48) The `raw_call` method is hereby removed in favor of the new `submit` method that has an extended ABI capable of returning a transaction's revert status and logged events. Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Arto Bendiken <arto@near.org> * Add benchmarks for common EVM operations. (#41) * Merge branch 'master' into improved-evm-token-logic * Update error handling to `master` * fix missing import * cargo fmt * Ensure ETH transfers return an execution result. (#48) * Update to `master` * fix str types Co-authored-by: Frank Braun <frank@near.org> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Arto Bendiken <arto@near.org>
mrLSD
added a commit
that referenced
this pull request
May 5, 2021
* Added prover & extended types * Mode Borsh args from types to parameters * Added fungible tokens * Added eth-connector * Modify assert for fee * Fix formatting * Extend eth-conenctor with EVM token logic * Changed eth-connector deposit logic * Added changes for ETH deposit/withdraw and Engine changes * Mint ETH-tokens * Added: transfer_eth * ETH withdraw basic method * eth-withdraw validation structure & modified Deposit-eth fields * eth transfer and withdraw logic * eip712 message verifier - started encoding * added encode-packed * virefy EIP712 message for withdraw * Changed EIP712 message fields * Modify logs for EIP712 messages * Test EIP712 * Tests EIP712 * Integration tests for encode_withdraw_eip712 * Integration tests for encode_withdraw_eip712 * EIP712-Withdraw: improvements and fixes. * EIP712-Withdraw: fixed encoding rules and order. * EIP712-Withdraw: `verify_withdraw_eip712` returns `true` only if the sender address equals to the address of message signer. * EIP712-Withdraw: update tests. * EIP712-Withdraw: refactoring. * ethabit::encode_token_packed: use right-padded encoding for `Address`. * WithdrawFromEthCallArgs: fixed `amount` type conversion. * Extend tests for eth-connector * eth-connector test deposit & balance & total_supply * Imporved tests * FT tests * Fixed verify_transfer_eip712 * Change test_withdraw_near * Tests for: ft_transfer, ft_transfer_call * test_eth_deposit_balance_total_supply * test and ifx: deposit_eth, withdraw_near * References in fungible token (#29) * Use references in fungible_token to avoid cloning * cargo fmt * Fix: hide logging behind feature flag * Remove eth-conenctor transfer methods and deposit for new design * Completed Deposit logic * Fix clippy; added comments; improved ft_transfer_call * Extend external functions for eth-connector * Added deploy_evm_token * Added ft_on_transfer logic * Changed ft_on_transfer & remove json depends * Changed deposit logic and fixed transfers * Added register relayer * Added message coder for ft_transfer_call * ft_on_transfer - added logic for erc20 * Impoved ft_on_transfer * ft_on_transfer: call erc20 contract adn send fee to Relayer. Added logs * eth-connector: Removed unsued methods * tests: deposit & fixed init test * tests: depoist, withdraw * tests: fix test_withdraw_near * Eth-connector: never skip bridge call. * Tests: fix ft_transfer_call * ft_transfer_call - changed gas amountr * Fixed: test_eth_deposit_balance_total_supply, test_ft_transfer * Added: test_ft_transfer_call_near_eth * Clippy fix * Added test_ft_transfer_call_erc20 * Added test_ft_transfer_call_erc20 * tests: ft_transfer_call for ERC20 changes * Fix finish_deposit - promise flow when failed for ft_transfer_call * added: test_deposit_with_same_proof * Improved EVM token master branch update (#50) * Link to docs in the README. (#18) * Change deprecated `u64::max_value` to `u64::MAX`. (#38) * Support custom error messages. (#40) * Implement `begin_chain` for evm-bully. (#30) * Implement a faucet method. (#39) * Implement all Istanbul HF precompiles. (#21) * Check and increment nonces. (#42) * Fix the RIPEMD160 and ModExp precompiles. (#44) * Implement a first draft of `COINBASE` and `GASLIMIT`. (#47) * Refactor and improve error handling. (#49) * Replace `raw_call` with the new `submit` API. (#48) The `raw_call` method is hereby removed in favor of the new `submit` method that has an extended ABI capable of returning a transaction's revert status and logged events. Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Arto Bendiken <arto@near.org> * Add benchmarks for common EVM operations. (#41) * Merge branch 'master' into improved-evm-token-logic * Update error handling to `master` * fix missing import * cargo fmt * Ensure ETH transfers return an execution result. (#48) * Update to `master` * fix str types Co-authored-by: Frank Braun <frank@near.org> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Arto Bendiken <arto@near.org> * Update src/connector.rs misspel Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> * Update src/connector.rs change constants error Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> Co-authored-by: Septen <gammerxpower@gmail.com> Co-authored-by: Michael Birch <michael@near.org> Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> Co-authored-by: Frank Braun <frank@near.org> Co-authored-by: Arto Bendiken <arto@near.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really small quality of life improvement which will just simply return the error messages contained in
Customoption.