Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evm-bully=yes build to CI #121

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Add evm-bully=yes build to CI #121

merged 1 commit into from
Jun 4, 2021

Conversation

frankbraun
Copy link
Contributor

The contract build for the evm-bully (make evm-bully=yes) often breaks.
Add it to CI to prevent that from happening.

@frankbraun frankbraun added C-enhancement Category: New feature or request A-ci Area: Continuous Integration (CI) labels Jun 3, 2021
@frankbraun frankbraun requested a review from artob June 3, 2021 05:44
Copy link
Contributor

@sept-en sept-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I also think that we should use develop as a base branch having the release protocol we have. I.e. the master points to the latest deployed version and the develop branch is the latest stable one that will be uploaded into master and released after that.

Copy link
Contributor

@artob artob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be targeted at develop, not master. And there are copy-paste artifacts to remove.

@artob artob assigned frankbraun and unassigned artob Jun 3, 2021
@frankbraun frankbraun changed the base branch from master to develop June 4, 2021 01:59
The contract build for the evm-bully (`make evm-bully=yes`) often breaks.
Add it to CI to prevent that from happening.
@frankbraun frankbraun force-pushed the build_bully_artifact branch from 74c49e8 to 9397db4 Compare June 4, 2021 02:17
@frankbraun
Copy link
Contributor Author

I changed it to target develop instead of master. Also moved the tests over to tests.yml, because this should be checked on every PR, not just for releases.

@artob artob merged commit 0f11b37 into develop Jun 4, 2021
@artob artob deleted the build_bully_artifact branch June 4, 2021 08:55
artob added a commit that referenced this pull request Jun 5, 2021
* Remove the dependency on Lunarity. (#115)
* Fix Clippy complaint with +nightly. (#117)
* Add an `evm-bully=yes` build to CI. (#121)
* Fix evm-bully builds. (#130)
* Handle transaction gas limit properly. (#123)
* Add an `is_used_proof` interface. (#120)
* Simplify the `sdk::read_u64` return type. (#118)

Co-authored-by: Frank Braun <frank@near.org>
Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com>
Co-authored-by: Kirill Abramov <septengineering@pm.me>
Co-authored-by: Michael Birch <michael@near.org>
artob added a commit that referenced this pull request Jun 17, 2021
* Introduce precompiles for the ETH & ERC-20 connectors. (#51)
* Implement generational storage with `SELFDESTRUCT` tests. (#84)
* Remove the dependency on Lunarity. (#115)
* Fix Clippy complaint with `+nightly`. (#117)
* Simplify the `sdk::read_u64` return type. (#118)
* Add an `is_used_proof` interface. (#120)
* Add an `evm-bully=yes` build to CI. (#121)
* Handle transaction gas limit properly. (#123)
* Fix u128 JSON parsing & tests in the ETH connector. (#125)
* Fix evm-bully builds. (#130)
* Add JSON custom error types. (#131)
* Don't burn NEP-141 on deposit. (#133)
* Fix needless borrows. (#135)
* Improve and refactor the ETH connector. (#136)
* Add a macro for logging. (#142)

Co-authored-by: Aleksey Kladov <aleksey@near.org>
Co-authored-by: Arto Bendiken <arto@aurora.dev>
Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev>
Co-authored-by: Frank Braun <frank@aurora.dev>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Co-authored-by: Kirill <kirill@aurora.dev>
Co-authored-by: Marcelo Fornet <marcelo@aurora.dev>
Co-authored-by: Michael Birch <michael@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration (CI) C-enhancement Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants