-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evm-bully=yes build to CI #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I also think that we should use develop
as a base branch having the release protocol we have. I.e. the master
points to the latest deployed version and the develop
branch is the latest stable one that will be uploaded into master
and released after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be targeted at develop
, not master
. And there are copy-paste artifacts to remove.
The contract build for the evm-bully (`make evm-bully=yes`) often breaks. Add it to CI to prevent that from happening.
74c49e8
to
9397db4
Compare
I changed it to target |
* Remove the dependency on Lunarity. (#115) * Fix Clippy complaint with +nightly. (#117) * Add an `evm-bully=yes` build to CI. (#121) * Fix evm-bully builds. (#130) * Handle transaction gas limit properly. (#123) * Add an `is_used_proof` interface. (#120) * Simplify the `sdk::read_u64` return type. (#118) Co-authored-by: Frank Braun <frank@near.org> Co-authored-by: Joshua J. Bouw <dev@joshuajbouw.com> Co-authored-by: Kirill Abramov <septengineering@pm.me> Co-authored-by: Michael Birch <michael@near.org>
* Introduce precompiles for the ETH & ERC-20 connectors. (#51) * Implement generational storage with `SELFDESTRUCT` tests. (#84) * Remove the dependency on Lunarity. (#115) * Fix Clippy complaint with `+nightly`. (#117) * Simplify the `sdk::read_u64` return type. (#118) * Add an `is_used_proof` interface. (#120) * Add an `evm-bully=yes` build to CI. (#121) * Handle transaction gas limit properly. (#123) * Fix u128 JSON parsing & tests in the ETH connector. (#125) * Fix evm-bully builds. (#130) * Add JSON custom error types. (#131) * Don't burn NEP-141 on deposit. (#133) * Fix needless borrows. (#135) * Improve and refactor the ETH connector. (#136) * Add a macro for logging. (#142) Co-authored-by: Aleksey Kladov <aleksey@near.org> Co-authored-by: Arto Bendiken <arto@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Frank Braun <frank@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Marcelo Fornet <marcelo@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
The contract build for the evm-bully (
make evm-bully=yes
) often breaks.Add it to CI to prevent that from happening.