chore(security): slither annotations

aurora-is-near · Dec 21, 2022 · 2b662ce · 2b662ce
1 parent 9fa519c
commit 2b662ce
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/etc/eth-contracts/contracts/AdminControlled.sol b/etc/eth-contracts/contracts/AdminControlled.sol
@@ -7,6 +7,7 @@ contract AdminControlled {
     uint public paused;
 
     constructor(address _admin, uint flags) {
+        // slither-disable-next-line missing-zero-check
         admin = _admin;
 
         // Add the possibility to set pause flags on the initialization
@@ -34,12 +35,14 @@ contract AdminControlled {
     }
 
     function adminSendEth(address payable destination, uint amount) public onlyAdmin {
+        // slither-disable-next-line missing-zero-check
         destination.transfer(amount);
     }
 
     function adminReceiveEth() public payable onlyAdmin {}
 
     function adminDelegatecall(address target, bytes memory data) public payable onlyAdmin returns (bytes memory) {
+        // slither-disable-next-line controlled-delegatecall,low-level-calls,missing-zero-check
         (bool success, bytes memory rdata) = target.delegatecall(data);
         require(success);
         return rdata;

diff --git a/etc/eth-contracts/contracts/EvmErc20.sol b/etc/eth-contracts/contracts/EvmErc20.sol
@@ -17,6 +17,7 @@ contract EvmErc20 is ERC20, AdminControlled, IExit {
     string private _symbol;
     uint8 private _decimals;
 
+    // slither-disable-next-line shadowing-local
     constructor (string memory metadata_name, string memory metadata_symbol, uint8 metadata_decimals, address admin)
         ERC20(metadata_name, metadata_symbol)
         AdminControlled(admin, 0)
@@ -38,6 +39,7 @@ contract EvmErc20 is ERC20, AdminControlled, IExit {
         return _decimals;
     }
 
+    // slither-disable-next-line events-maths
     function setMetadata(string memory metadata_name, string memory metadata_symbol, uint8 metadata_decimals) external onlyAdmin {
         _name = metadata_name;
         _symbol = metadata_symbol;

diff --git a/etc/eth-contracts/contracts/EvmErc20V2.sol b/etc/eth-contracts/contracts/EvmErc20V2.sol
@@ -17,6 +17,7 @@ contract EvmErc20V2 is ERC20, AdminControlled, IExit {
     string private _symbol;
     uint8 private _decimals;
 
+    // slither-disable-next-line shadowing-local
     constructor (string memory metadata_name, string memory metadata_symbol, uint8 metadata_decimals, address admin)
         ERC20(metadata_name, metadata_symbol)
         AdminControlled(admin, 0)
@@ -38,6 +39,7 @@ contract EvmErc20V2 is ERC20, AdminControlled, IExit {
         return _decimals;
     }
 
+    // slither-disable-next-line events-maths
     function setMetadata(string memory metadata_name, string memory metadata_symbol, uint8 metadata_decimals) external onlyAdmin {
         _name = metadata_name;
         _symbol = metadata_symbol;