-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github ignore support #22
Comments
What is "ignores from here"? |
"from here" is the link. I guess I should reorder my wording |
I prefer to ship a default (and improved) Right now, everything is minimum in this repo to keep it easy to maintain. |
Pls PR in to fill the gap of our gitignore. Pls don't create new question for end users to choose. For those seems too much beyond the scope of this project, pls follow the guide in our gitignore file # We recommend that you use a Global Gitignore for files that are not related
# to the project. (https://help.github.com/articles/ignoring-files/#create-a-global-gitignore) |
this is a good idea in theory... but do you have a global gitignore? I never have in the last... 12? years of using git. new questions may or may not be right, maybe it'd be better to add all the OS ones by default, and node. If later we add questions about IDEs/editors, then it would be good to add their templates dynamically. |
I do have a global one. But I agree it's good idea to add all OS/node ones by default, unless it's too rare to common users. Feel free to PR in. |
My thought is to add it by fetching it from the github repo at runtime (presuming that is possible) |
There is customise point https://makes.js.org/before-and-after-tasks#after-task If there is something missing, why not just add in common ignores? |
my thought process is that if we fetch them at runtime, instead of baking them in, they'll be up to date with any changes. I don't have to do that though. |
I see, but I cannot imagine they will be updated too often (even per year), especially the JS area. If you want, you can try to use |
add archives, windows, mac, linux, and nodeignore
finally got around to a PR for this |
would be really cool if the prompter could ask you if you want ignores from here https://github.com/github/gitignore, this is non critical to me just an idea.
The text was updated successfully, but these errors were encountered: