Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github ignore support #22

Closed
xenoterracide opened this issue Apr 18, 2020 · 11 comments
Closed

github ignore support #22

xenoterracide opened this issue Apr 18, 2020 · 11 comments

Comments

@xenoterracide
Copy link

xenoterracide commented Apr 18, 2020

would be really cool if the prompter could ask you if you want ignores from here https://github.com/github/gitignore, this is non critical to me just an idea.

@3cp
Copy link
Member

3cp commented Apr 18, 2020

What is "ignores from here"?

@xenoterracide
Copy link
Author

"from here" is the link. I guess I should reorder my wording

@3cp
Copy link
Member

3cp commented Apr 18, 2020

I prefer to ship a default (and improved) .gitignore, instead of providing users too many options.

Right now, everything is minimum in this repo to keep it easy to maintain.
PR is welcome to enhance the .gitignore.

@3cp
Copy link
Member

3cp commented Apr 19, 2020

Pls PR in to fill the gap of our gitignore. Pls don't create new question for end users to choose.

For those seems too much beyond the scope of this project, pls follow the guide in our gitignore file

# We recommend that you use a Global Gitignore for files that are not related
# to the project. (https://help.github.com/articles/ignoring-files/#create-a-global-gitignore)

@xenoterracide
Copy link
Author

xenoterracide commented Apr 20, 2020

We recommend that you use a Global Gitignore for files that are not related

this is a good idea in theory... but do you have a global gitignore? I never have in the last... 12? years of using git.

new questions may or may not be right, maybe it'd be better to add all the OS ones by default, and node.

If later we add questions about IDEs/editors, then it would be good to add their templates dynamically.

@3cp
Copy link
Member

3cp commented Apr 20, 2020

I do have a global one. But I agree it's good idea to add all OS/node ones by default, unless it's too rare to common users. Feel free to PR in.

@xenoterracide
Copy link
Author

My thought is to add it by fetching it from the github repo at runtime (presuming that is possible)

@3cp
Copy link
Member

3cp commented Apr 20, 2020

There is customise point https://makes.js.org/before-and-after-tasks#after-task
But I do think the complexity of this feature is not justified due to user demand.

If there is something missing, why not just add in common ignores?

@xenoterracide
Copy link
Author

my thought process is that if we fetch them at runtime, instead of baking them in, they'll be up to date with any changes. I don't have to do that though.

@3cp
Copy link
Member

3cp commented Apr 20, 2020

I see, but I cannot imagine they will be updated too often (even per year), especially the JS area.
It's not a big burden to manually update this repo whenever needed.

If you want, you can try to use after task to synthesis a gitignore file.

xenoterracide added a commit to xenoterracide/new that referenced this issue May 22, 2020
add archives, windows, mac, linux, and nodeignore
@xenoterracide
Copy link
Author

finally got around to a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants