-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch build system to Browserify #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2014
👍 |
devongovett
added a commit
that referenced
this pull request
Jun 17, 2014
Switch build system to Browserify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the build system from Importer to Browserify. Importer was kinda okish, but was buggy and suboptimal in terms of isolating modules, and our Node support was shabby at best because of it. Browserify fixes these problems: it's well maintained, uses a standardized module system (CommonJS, or more specifically, Node's module system), and makes Node and browsers able to use the same code easily. It will also allow us to use some of Node's features in the future, such as streams perhaps (I need to investigate this more).
This should cause no difference to the API. In browsers, a module is exported for CommonJS and AMD, and falls back to the
AV
global as before. In node, the API did change. We no longer need the specialAV.require
function to load codecs. You can now justrequire
them normally:I will publish aurora and all the codecs on npm, as well as upload prebuild versions (with source maps) to Github's releases tab as we release new versions. All of this is in the new
Makefile
. At some point I'd like to separate the currently built-in decoders and demuxers into their own modules on npm and in Github too so people have more control over what is included in their build.Hopefully this will make things easier to build and debug, and easier to understand for newcomers to the project. 😄