audcore: Prevent buffer overflow. Closes: #1541

When iterating the default configuration settings we did not properly check for the array end, leading to an invalid out-of-bounds access.
audacious-media-player · Jan 5, 2025 · b19b438 · b19b438
1 parent a388e0a
commit b19b438
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/libaudcore/config.cc b/src/libaudcore/config.cc
@@ -345,8 +345,11 @@ EXPORT void aud_config_set_defaults(const char * section,
     while (1)
     {
         const char * name = *entries++;
+        if (!name)
+            break;
+
         const char * value = *entries++;
-        if (!name || !value)
+        if (!value)
             break;
 
         ConfigOp op = {OP_SET_NO_FLAG, section, name, String(value)};