fix(wrapped): fix crash when history is empty #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellie
approved these changes
Jan 7, 2025
enchantednatures
pushed a commit
to enchantednatures/atuin
that referenced
this pull request
Jan 16, 2025
* fix(wrapped): fix crash when history is empty * style: fix format
enchantednatures
pushed a commit
to enchantednatures/atuin
that referenced
this pull request
Jan 16, 2025
* fix(wrapped): fix crash when history is empty * style: fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Details
I noticed a crash when there is no history entries for the specified year, 2023 in my case, so I added a simple check and message.
I'm not sure of the behavior if someone has no history for 2023 but has some for 2024 and does a
atuin import. If it's not recommened, please let me know and I will update the error message. Feel free to change it too.Before:
After:
