Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Python 3.10 #315

Merged
merged 15 commits into from
Aug 21, 2022
Merged

Check Python 3.10 #315

merged 15 commits into from
Aug 21, 2022

Conversation

attzonko
Copy link
Owner

Checking if any issues are going to show in 3.10

attzonko added 2 commits June 18, 2022 11:41
@attzonko
Check Python 3.10
49ad893 
Checking if any issues are going to show in 3.10
@attzonko
Update test.yml
7796092
@attzonko attzonko marked this pull request as draft June 18, 2022 18:45
@unode
Copy link
Collaborator

unode commented Jul 15, 2022

The failure in this issue is caused by the same as #319
Should be safe to merge once the other is fixed.

@attzonko
Copy link
Owner Author

The failure in this issue is caused by the same as #319 Should be safe to merge once the other is fixed.

I agree, but I am not coming up with a simple fix. And I don't want to disable the typing check...

@unode
Copy link
Collaborator

unode commented Jul 20, 2022 •
edited
Loading

I will give it a shot later today. I think the solution is to add default (= None) values to the base Function class or create a Union type for those arguments.
There are some attributes that are only available in click_functions and the type-checking is being done against a more generic Callable type.

@attzonko attzonko marked this pull request as ready for review August 18, 2022 15:03
@attzonko
Copy link
Owner Author

@unode Not the cleanest but I think it should work. Thoughts?

unode
unode reviewed Aug 19, 2022
View reviewed changes
mmpy_bot/function.py Outdated Show resolved Hide resolved
unode
unode reviewed Aug 19, 2022
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
unode
unode reviewed Aug 19, 2022
View reviewed changes
mmpy_bot/function.py Outdated Show resolved Hide resolved
mmpy_bot/function.py Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 21, 2022

Code Climate has analyzed commit 1e94d5c and detected 0 issues on this pull request.

View more on Code Climate.

@attzonko attzonko merged commit 8c66ab8 into main Aug 21, 2022
@unode unode deleted the attzonko-check-3.10 branch August 21, 2022 22:08
unode added a commit to unode/mmpy_bot that referenced this pull request Feb 9, 2023
@attzonko @unode
Check Python 3.10 (attzonko#315)
d30fb5e 
* Adding Python 3.10 Support
* Use Ubuntu 22.04 instead of 20.04 for Testing

Co-authored-by: Renato Alves <alves.rjc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unode unode unode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attzonko @unode