A few minor logging enhancements #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneeven
approved these changes
Apr 6, 2021
Comment on lines
31
to
39
| logging.basicConfig( | ||
| **{ | ||
| "format": "[%(asctime)s] %(message)s", | ||
| "format": self.settings.LOG_FORMAT, | ||
| "datefmt": "%m/%d/%Y %H:%M:%S", | ||
| "level": logging.DEBUG if self.settings.DEBUG else logging.INFO, | ||
| "stream": sys.stdout, | ||
| "filename": self.settings.LOG_FILE, | ||
| "filemode": "w", | ||
| } | ||
| ) |
There was a problem hiding this comment.
Will the format be used globally? Or only for the logger in this file?
There was a problem hiding this comment.
The current implementation is that the LOG_FORMAT from settings is used for both the console login to stdout and the log file. However, if you think we should provide independent FORMAT settings for each I am fine with that. My goal was to provide some flexibility while still having a sane default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bit clearer logging and the ability to also log to a file if the LOG_FILE setting is set.