Add supp tbl #38
Add supp tbl #38
Conversation
…les need derivations
…delist but it is missing
Codecov Report
@@ Coverage Diff @@
## dev #38 +/- ##
==========================================
- Coverage 85.30% 84.29% -1.02%
==========================================
Files 6 6
Lines 871 923 +52
==========================================
+ Hits 743 778 +35
- Misses 128 145 +17
Continue to review full report at Codecov.
|
| codes = "List of Codes") | ||
|
|
||
| private$.supp <- supp %>% | ||
| add_labs(dataset = "Dataset Name", |
There was a problem hiding this comment.
@statasaurus is the assumption that the variable would also live in var_spec and flagged as a supp? And QORIG based on derivations?
There was a problem hiding this comment.
No the QORIG would be base on the origin. You shouldn't need to have a supp flag in var_spec or value_spec cause the information will be pulled from ds_vars. The plan would be you would treat your supp variable like any other. Add the label to the label caloumn in var_spec, add information about how it is derived in derivations and any origin, codelist etc. information in the value_spec
There was a problem hiding this comment.
Before we polish this off, could you put together an example to merge the necessary info from valtools and push into the supp building functions? Before we call this final I just want to make sure that we have that metcaore -> metatools -> supp dataset workflow locked down.
There was a problem hiding this comment.
... valtools? Did you mean metatools? The example is here. I have created a mock metacore sdtm object which is already in the dev branch that has some supp stuff it in. I am planning on writing a where to add my supp information vingette.
No description provided.