Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yn_to_tf: additional fix needed #57

Closed
esimms999-gsk opened this issue Sep 19, 2022 · 2 comments
Closed

yn_to_tf: additional fix needed #57

esimms999-gsk opened this issue Sep 19, 2022 · 2 comments

Comments

@esimms999-gsk
Copy link
Contributor

Left is "main" branch, right is "dev" branch. The change was made to address Issue #47 .

Screenshot 2022-09-16 104705

There needs to be an additional, small change made to the regex:

if(all(is.na(x) | str_detect(x, regex("^y$|^n$|yes$|no$", ignore_case = T)))){
case_when(str_detect(x, regex("^y$|yes$", ignore_case = T)) ~ TRUE,
str_detect(x, regex("^n$|no$", ignore_case = T)) ~ FALSE,

"ABCy" would be set to NA. But "ABCyes" would be set to TRUE. Same with "ABCn" vs "ABCno" being set to NA vs FALSE.

@esimms999-gsk
Copy link
Contributor Author

Created fork and PR #59 with modification to yn_to_tf in dev branch.

statasaurus added a commit that referenced this issue Sep 28, 2022
Minor change to yn_to_tf function in the dev branch wrt metacore Issue #57
@mstackhouse
Copy link
Contributor

Merged in #59 to dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants