-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yn_to_tf: additional fix needed #57
Comments
esimms999-gsk
added a commit
to esimms999-gsk/metacore_issue_57
that referenced
this issue
Sep 22, 2022
Created fork and PR #59 with modification to yn_to_tf in dev branch. |
statasaurus
added a commit
that referenced
this issue
Sep 28, 2022
Minor change to yn_to_tf function in the dev branch wrt metacore Issue #57
Merged in #59 to dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Left is "main" branch, right is "dev" branch. The change was made to address Issue #47 .
There needs to be an additional, small change made to the regex:
if(all(is.na(x) | str_detect(x, regex("^y$|^n$|yes$|no$", ignore_case = T)))){
case_when(str_detect(x, regex("^y$|yes$", ignore_case = T)) ~ TRUE,
str_detect(x, regex("^n$|no$", ignore_case = T)) ~ FALSE,
"ABCy" would be set to NA. But "ABCyes" would be set to TRUE. Same with "ABCn" vs "ABCno" being set to NA vs FALSE.
The text was updated successfully, but these errors were encountered: