fix(x/photon): wrong codec for GetSignBytes

atomone-hub · Jan 10, 2025 · 309ccbe · 309ccbe
1 parent 066d7db
commit 309ccbe
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 1 deletion.
diff --git a/x/photon/types/codec.go b/x/photon/types/codec.go
@@ -24,7 +24,7 @@ func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {
 
 var (
 	amino     = codec.NewLegacyAmino()
-	ModuleCdc = codec.NewProtoCodec(cdctypes.NewInterfaceRegistry())
+	ModuleCdc = codec.NewAminoCodec(amino)
 )
 
 func init() {

diff --git a/x/photon/types/msgs_test.go b/x/photon/types/msgs_test.go
@@ -65,3 +65,48 @@ func TestMsgMintPhoton_ValidateBasic(t *testing.T) {
 		})
 	}
 }
+
+func TestMsgMintPhoton_GetSignBytes(t *testing.T) {
+	msg := MsgMintPhoton{
+		ToAddress: "my_addr",
+		Amount:    sdk.NewInt64Coin("uatone", 1),
+	}
+
+	bz := msg.GetSignBytes()
+
+	expectedSignedBytes := `{
+		"type": "atomone/photon/v1/MsgMintPhoton",
+		"value": {
+			"amount": {
+				"amount":"1",
+				"denom": "uatone"
+			},
+			"to_address": "my_addr"
+		}
+	}`
+	require.JSONEq(t, expectedSignedBytes, string(bz))
+}
+
+func TestMsgUpdateParams_GetSignBytes(t *testing.T) {
+	msg := MsgUpdateParams{
+		Authority: "authority",
+		Params: Params{
+			MintDisabled:    true,
+			TxFeeExceptions: []string{"tx1", "tx2"},
+		},
+	}
+
+	bz := msg.GetSignBytes()
+
+	expectedSignedBytes := `{
+		"type": "atomone/x/photon/v1/MsgUpdateParams",
+		"value": {
+			"authority":"authority",
+			"params": {
+				"mint_disabled":true,
+				"tx_fee_exceptions": ["tx1","tx2"]
+			}
+		}
+	}`
+	require.JSONEq(t, expectedSignedBytes, string(bz))
+}