Release 0.25.3 and fix Parameter decorator

CHANGELOG.md

@@ -7,7 +7,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/atomist/rug/compare/0.25.2...HEAD
+[Unreleased]: https://github.com/atomist/rug/compare/0.25.3...HEAD
+
+## [0.25.3] - 2017-04-13
+
+[0.25.3]: https://github.com/atomist/rug/compare/0.25.2...0.25.3
+
+Parameter release
+
+### Changed
+
+-   Parameter decorator now takes a copy of the parameter configuration.
+    It _was_ overwriting its contents.
 
 ## [0.25.2] - 2017-04-13
 

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>com.atomist</groupId>
     <artifactId>rug</artifactId>
-    <version>0.26.0-SNAPSHOT</version>
+    <version>0.25.3</version>
     <packaging>jar</packaging>
     <name>rug</name>
     <description>Rug Runtime</description>

src/test/resources/com/atomist/rug/runtime/js/interop/SimpleCommandHandlerWithSameParametersConfig.ts

@@ -0,0 +1,21 @@
+import {HandleCommand, Instruction, Response, HandlerContext, Plan, DirectedMessage, UserAddress} from '@atomist/rug/operations/Handlers'
+import {CommandHandler, Parameter, Tags, Intent} from '@atomist/rug/operations/Decorators'
+import {Build} from "@atomist/rug/cortex/stub/Build"
+
+let config = {description: "desc", pattern: "@any"}
+
+@CommandHandler("SameConfig", "Uses same config object")
+class SameConfig implements HandleCommand{
+
+  @Parameter(config)
+  foo: number
+
+  @Parameter(config)
+  bar: number
+
+  handle(ctx: HandlerContext) {
+      return new Plan();
+  }
+}
+
+export let command = new SameConfig();

src/test/scala/com/atomist/rug/runtime/js/JavaScriptCommandHandlerTest.scala

@@ -53,6 +53,19 @@ class JavaScriptCommandHandlerTest extends FlatSpec with Matchers {
   val simpleCommandHandlerWithBadStubUse = StringFileArtifact(atomistConfig.handlersRoot + "/Handler.ts",
     contentOf(this, "SimpleCommandHandlerWithBadStubUse.ts"))
 
+  val simpleCommandHandlerWithSameParametersConfig = StringFileArtifact(atomistConfig.handlersRoot + "/Handler.ts",
+    contentOf(this, "SimpleCommandHandlerWithSameParametersConfig.ts"))
+
+  it should "not overwrite parameters when we reuse the same parametes object" in {
+    val rugArchive = TypeScriptBuilder.compileWithExtendedModel(
+      SimpleFileBasedArtifactSource(simpleCommandHandlerWithSameParametersConfig))
+    val rugs = RugArchiveReader(rugArchive)
+    val handler = rugs.commandHandlers.head
+    val params = handler.parameters
+    assert(params.head.name == "foo")
+    assert(params(1).name == "bar")
+  }
+
   it should "#488: get good error message from generated model stubs" in {
     val rugArchive = TypeScriptBuilder.compileWithExtendedModel(
       SimpleFileBasedArtifactSource(simpleCommandHandlerWithBadStubUse))