Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code lint #191

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Add code lint #191

merged 3 commits into from
Jun 4, 2024

Conversation

shadowv0vshadow
Copy link
Collaborator

Add .pre-commit-config.yaml for lint in git commit. And add lint CI for lint.

If you want use lint tool, you should install pre-commit. i add pre-commit in requirements.txt.

Github action:

name: Lint code

on: [push, pull_request]

permissions:
  contents: read

jobs:
  lint:
    runs-on: ubuntu-20.04
    timeout-minutes: 10

    steps:
    - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
    - name: Set up Python
      uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
      with:
        python-version: "3.x"
    - name: Run pre-commit
      uses: pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507 # v3.0.0

Maybe We can also use pyproject.toml manage project later

@wizz-wallet-dev
Copy link
Collaborator

Putting this as a draft until we've merged other requests. Thanks for the huge step!

@wizz-wallet-dev wizz-wallet-dev marked this pull request as draft May 30, 2024 16:07
@shadowv0vshadow shadowv0vshadow marked this pull request as ready for review June 4, 2024 02:05
@shadowv0vshadow shadowv0vshadow merged commit 2dd3018 into develop Jun 4, 2024
4 checks passed
@wizz-wallet-dev wizz-wallet-dev deleted the feat/lint branch June 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants