Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preconfig Testnet4 #188

Merged
merged 1 commit into from
May 29, 2024
Merged

Preconfig Testnet4 #188

merged 1 commit into from
May 29, 2024

Conversation

wizz-wallet-dev
Copy link
Collaborator

@wizz-wallet-dev wizz-wallet-dev marked this pull request as ready for review May 28, 2024 14:23
@wizz-wallet-dev
Copy link
Collaborator Author 

{
    "coin": "BitcoinTestnet4",
    "network": "testnet4",
    "block_tip": "0000000000000a73b001701a2839aea05ea054466673f7296807227a332412f4",
    "atomicals_block_tip": "4408a9070fde93e51ee8331b2fa0835d93df087383dda25d9c06d2d7ded4f178",
    "atomical_count": 0,
    "atomicals_block_hashes": {
        "27615": "4408a9070fde93e51ee8331b2fa0835d93df087383dda25d9c06d2d7ded4f178",
        "27614": "0a9f0bfcfcf4beec73cd908f0c9da8f41786756d7c23a0e8b9aad859caf1ca71",
        "27613": "8dead53cf4a29b7455dc1c1df0415c6554973c8ffaa53aad480b0e9f975d53c8",
        "27612": "23cda97fb2cfbef28bd6eff412d01941f232c9e6bc8aba7a06475ff5e6aaa64b",
        "27611": "ebd33ad1a8db1ed401964ce39977d3d058a96fbe9b8707a391da9cb342b1afdc",
        "27610": "7b2ffd5e32a1c2497014c18e7f8265b930f4ced31ef42e4a07ec51ed6be8481e",
        "27609": "a780b5d5934fe46a056d9eeb332274adbd209c97ef71e1b4a84d0c347266bf56",
        "27608": "d12ea70e61a0e7b438d92de2b75a6755e91dcc1e41617a3b601d29082448d456",
        "27607": "44347fe0bc3439799a6717e40205204878f35ff8fa544e810b1649bf3f7d23fe",
        "27606": "17d151b3dbb5a1a909a5cb6bef5a9e7ad1712142aef0c4c0a32d91fbd27c0eff"
    }
}

atomicals
atomicals approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@atomicals atomicals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

atomicals
atomicals reviewed May 28, 2024
View reviewed changes
electrumx/lib/coins.py
ATOMICALS_ACTIVATION_HEIGHT_DFT_BITWORK_ROLLOVER = 27000
ATOMICALS_ACTIVATION_HEIGHT_CUSTOM_COLORING = 27000

@classmethod
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this warning needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It keeps the previous code references work.

@wizz-wallet-dev wizz-wallet-dev merged commit e99550a into develop May 29, 2024
2 checks passed
@wizz-wallet-dev wizz-wallet-dev deleted the feat/testnet4 branch May 29, 2024 01:49
@wizz-wallet-dev wizz-wallet-dev mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomicals atomicals atomicals approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizz-wallet-dev @atomicals