Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split shared sessions #185

Merged
merged 14 commits into from
May 29, 2024
Merged

Split shared sessions #185

merged 14 commits into from
May 29, 2024

Conversation

wizz-wallet-dev
Copy link
Collaborator

@wizz-wallet-dev wizz-wallet-dev commented May 20, 2024

Uses a shared session instance to unify handlers between different sessions.

  • Abstract shared sessions.
  • Clean and improve sessions definitions.
  • Move handlers to the shared session.

Other Changes

/proxy/server.info has been added to obtain the actual Atomicals Indexer Node version and what AIPs did the node have implemented.

Result example:

{
  "success": true,
  "response": {
    "aip_implemented": [1, 3],
    "version": "1.5.0.0"
  }
}

@wizz-wallet-dev wizz-wallet-dev marked this pull request as ready for review May 28, 2024 17:03
Copy link
Owner

@atomicals atomicals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -847,7 +853,7 @@ def hashX_from_script(cls, script):
return super().hashX_from_script(address_script)


class BitcoinTestnetMixin:
class BitcoinTestnetMixin(CoinShortNameMixin):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the mixin not needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does. The short name still referenced in the RPC queries, implementing CoinShortNameMixin helps the query method recognize the type source.

@wizz-wallet-dev wizz-wallet-dev merged commit c4157ea into develop May 29, 2024
2 checks passed
@wizz-wallet-dev wizz-wallet-dev deleted the feat/shared-session branch May 29, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants