-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split shared sessions #185
Conversation
983c442
to
1cdab9d
Compare
23fc428
to
3e217e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -847,7 +853,7 @@ def hashX_from_script(cls, script): | |||
return super().hashX_from_script(address_script) | |||
|
|||
|
|||
class BitcoinTestnetMixin: | |||
class BitcoinTestnetMixin(CoinShortNameMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the mixin not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does. The short name still referenced in the RPC queries, implementing CoinShortNameMixin
helps the query method recognize the type source.
# Conflicts: # electrumx/server/session.py
Uses a shared session instance to unify handlers between different sessions.
Other Changes
/proxy/server.info
has been added to obtain the actual Atomicals Indexer Node version and what AIPs did the node have implemented.Result example: